Skip to content

feat: expose bringToFront() method #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BeksOmega merged 3 commits into from
Aug 7, 2024
Merged

feat: expose bringToFront() method #8472

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e495dd5
Remove internal from bringToFront JSDoc
UCYT5040 Aug 7, 2024
a90e09c
Add a note about the cost of this method
UCYT5040 Aug 7, 2024
e6fcc05
Remove unnecessary colon
UCYT5040 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/block_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1171,10 +1171,11 @@ export class BlockSvg
* <g> tags do not respect z-index so SVG renders them in the
* order that they are in the DOM. By placing this block first within the
* block group's <g>, it will render on top of any other blocks.
* Use sparingly, this method is expensive because it reorders the DOM
* nodes.
*
* @param blockOnly: True to only move this block to the front without
* @param blockOnly True to only move this block to the front without
* adjusting its parents.
* @internal
*/
bringToFront(blockOnly = false) {
/* eslint-disable-next-line @typescript-eslint/no-this-alias */
Expand Down