Skip to content

refactor: make CommentView more amenable to subclassing. #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 1 commit into from
Feb 24, 2025
Merged

refactor: make CommentView more amenable to subclassing. #8783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/comments/comment_view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,18 @@ export class CommentView implements IRenderedElement {
private resizePointerMoveListener: browserEvents.Data | null = null;

/** Whether this comment view is currently being disposed or not. */
private disposing = false;
protected disposing = false;

/** Whether this comment view has been disposed or not. */
private disposed = false;
protected disposed = false;

/** Size of this comment when the resize drag was initiated. */
private preResizeSize?: Size;

/** The default size of newly created comments. */
static defaultCommentSize = new Size(120, 100);

constructor(private readonly workspace: WorkspaceSvg) {
constructor(readonly workspace: WorkspaceSvg) {
this.svgRoot = dom.createSvgElement(Svg.G, {
'class': 'blocklyComment blocklyEditable blocklyDraggable',
});
Expand Down