Skip to content

Conversation

@gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #9141
Fixes #9144

Proposed Changes

This PR updates the localizable messages used in the keyboard-experiment repo. Specifically, it:

  • Removes some messages that are no longer used in the keyboard-experiment repo, and were recently added in order to support it (ie, they have no other uses)
  • Removes placeholders for keyboard shortcuts in some messages now that shortcuts are presented better in the contextual menu
  • Adds several additional messages for use in toasts.

@gonfunko gonfunko requested a review from a team as a code owner June 17, 2025 22:40
@gonfunko gonfunko requested a review from cpcallen June 17, 2025 22:40
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Jun 17, 2025
Copy link
Collaborator

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware that the changes made to msg/en.json will get overwritten next time we pull in updates from translatewiki (using the day-of-release documented procedure) unless the translatewiki branch is also updated. Unfortunately AFAIK we do not currently have a documented procedure for how to update the translatewiki branch from develop.

#6312 might be relevant background reading.

@gonfunko gonfunko merged commit 28d6ff7 into RaspberryPiFoundation:develop Jun 23, 2025
11 checks passed
@gonfunko gonfunko deleted the messages branch June 23, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

2 participants