-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: Fix typo in unregisterWorkspace function name #9559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
|
Incredible, this typo has been here for at least 4 years undetected. Unfortunately changing it directly like this would be a breaking change, in case anyone's using the old name. We need to:
Let us know if you're still interested in fixing this with these additional steps. Thanks! |
|
Added |
maribethb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! One suggestion then lgtm.
Co-authored-by: Maribeth Moffatt <mebottorff@gmail.com>
The basics
The details
Resolves
Fixes
Proposed Changes
Fix typo in unregisterWorkspace function name