Skip to content

Conversation

@suk-6
Copy link

@suk-6 suk-6 commented Jan 9, 2026

The basics

The details

Resolves

Fixes

Proposed Changes

Fix typo in unregisterWorkspace function name

@suk-6 suk-6 requested a review from a team as a code owner January 9, 2026 06:16
@suk-6 suk-6 requested a review from maribethb January 9, 2026 06:16
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 9, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@maribethb
Copy link
Contributor

maribethb commented Jan 9, 2026

Incredible, this typo has been here for at least 4 years undetected.

Unfortunately changing it directly like this would be a breaking change, in case anyone's using the old name. We need to:

  • Add a new, correctly spelled function, like you've done here.
  • Keep the old misspelled one and just have it call the new one.
  • Add a deprecation warning to the old one that it will be removed in v13.
  • Add a rename to the migration database so that folks can automatically update their code when migrating to v13.
  • Update the internal usages of the function.

Let us know if you're still interested in fixing this with these additional steps. Thanks!

@suk-6
Copy link
Author

suk-6 commented Jan 10, 2026

Added unregisterWorkpace to the migration database. Is this the right approach?

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! One suggestion then lgtm.

Co-authored-by: Maribeth Moffatt <mebottorff@gmail.com>
@suk-6 suk-6 requested a review from maribethb January 14, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants