Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniqueness for user projects in DB #156

Merged
merged 9 commits into from
Mar 9, 2023
Merged

Uniqueness for user projects in DB #156

merged 9 commits into from
Mar 9, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Mar 6, 2023 •
edited by loiswells97
Loading

What's Changed?

  • Added project model validations to ensure only one user can own projects with a given identifier and that RPF projects have a locale
  • Slight PhraseGenerator refactor to ensure phrases generated are always unique
  • Ensure remix generates its own identifier and sets locale to nil

closes #143

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-issues-143-kngueo March 6, 2023 13:53 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 6, 2023 14:15 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 6, 2023 16:38 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 7, 2023 17:40 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 8, 2023 09:27 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 8, 2023 10:57 Inactive
@loiswells97 loiswells97 temporarily deployed to editor-api-p-issues-143-kngueo March 8, 2023 11:00 Inactive
@loiswells97 loiswells97 marked this pull request as ready for review March 8, 2023 11:09
IzzySmillie
IzzySmillie approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really clear.

Looks good to me! 🚀

@IzzySmillie IzzySmillie mentioned this pull request Mar 8, 2023
Closed
patch0
patch0 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The move of the PhraseIdentifier work into its own module works well.

@loiswells97 loiswells97 merged commit a3e4845 into main Mar 9, 2023
@loiswells97 loiswells97 deleted the issues/143-Uniqueness_for_user_projects_in_DB branch March 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IzzySmillie IzzySmillie IzzySmillie approved these changes

@patch0 patch0 patch0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniqueness for user projects in DB
4 participants
@patch0 @IzzySmillie @raspberrypiherokubot @loiswells97