Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PhraseIdentifier fails in consistent ways #159

Merged
merged 5 commits into from
Mar 10, 2023

Conversation

patch0
Copy link
Contributor

@patch0 patch0 commented Mar 9, 2023

  • Remove unlimimted retries, raising an error after 10
  • Raises an error if no words are found in the list
  • refactor #unique? to be more specific SQL

* Remove unlimimted retries, raising an error after 10
* Raises an error if no words are found in the list
* refactor `#unique?` to be more specific SQL
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-robustify--8ss7rw March 9, 2023 18:15 Inactive
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-robustify--d8d2za March 9, 2023 18:16 Inactive
@patch0 patch0 marked this pull request as ready for review March 10, 2023 09:24
patch0 added 2 commits March 10, 2023 09:29
…oundation/choco-cake into robustify-phrase-identifier
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-robustify--pywyw5 March 10, 2023 09:30 Inactive
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-robustify--erzzpp March 10, 2023 09:43 Inactive
@patch0 patch0 merged commit f74c4e3 into main Mar 10, 2023
@patch0 patch0 deleted the robustify-phrase-identifier branch March 10, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants