Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate projects with user IDs in the model #18

Merged
merged 10 commits into from
Feb 25, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Feb 24, 2022

Closes #16

  • Moves remix endpoint to it's own controller to be more RESTful
  • Create operation to handle business logic
  • Ensure user_id is stored against remixed project

Sending the User ID in the request body is not ideal and will be changed to require a user token to be included in the request header. The API can then check this via Hydra to authorize the user and obtain user details.
This would prevent anybody from being able to create content under another users details (as the API is public)

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

Move logic into operation class to allow easier testing and keep
controllers thin
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@ArayB ArayB self-assigned this Feb 25, 2022
@ArayB ArayB marked this pull request as ready for review February 25, 2022 09:35
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ArayB ArayB merged commit 4b4fd19 into main Feb 25, 2022
@ArayB ArayB deleted the issues/16-Associate_projects_with_user_IDs_in_the_model branch February 25, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associate projects with user IDs in the model
3 participants