-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate projects with user IDs in the model #18
Merged
ArayB
merged 10 commits into
main
from
issues/16-Associate_projects_with_user_IDs_in_the_model
Feb 25, 2022
Merged
Associate projects with user IDs in the model #18
ArayB
merged 10 commits into
main
from
issues/16-Associate_projects_with_user_IDs_in_the_model
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move logic into operation class to allow easier testing and keep controllers thin
loiswells97
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
ArayB
deleted the
issues/16-Associate_projects_with_user_IDs_in_the_model
branch
February 25, 2022 11:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Sending the User ID in the request body is not ideal and will be changed to require a user token to be included in the request header. The API can then check this via Hydra to authorize the user and obtain user details.
This would prevent anybody from being able to create content under another users details (as the API is public)