Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle project images when remixing #49

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Handle project images when remixing #49

merged 5 commits into from
Apr 6, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Apr 1, 2022 •
edited by ArayB
Loading

closes #48

  • When remixing a project attaches images from original project to remixed version.
  • When creating starter projects in rake task:
    • only remove images that have altered then upload new version
    • delete images removed from project

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

ArayB added 2 commits April 1, 2022 14:04
@ArayB
Set images to purge after deleting project
f4cc4d8
@ArayB
Amend projects rake task
38462cc 
If project image already exists skip it instead of deleting and
uploading again.
Delete image if it has changed.
@raspberrypigithubbot
Copy link

@raspberrypigithubbot
Copy link

@ArayB ArayB marked this pull request as ready for review April 1, 2022 14:56
loiswells97
loiswells97 reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sHtev and I have been discussing this here and our main question is whether pruning images from projects is deleting the image or just the association? If deleting the image then we were thinking it would break child projects if an image is deleted from the parent. If just the association, then is there any mileage in including a test that shows that the child still has the image after deleting it from the parent, or that the number of associations has decreased but the number of images has stayed the same (like a parallel to lines 67-73 in create_remix_spec)?

@sHtev sHtev merged commit b871ee1 into main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loiswells97 loiswells97 loiswells97 left review comments

@sHtev sHtev sHtev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle project images when remixing
4 participants
@raspberrypigithubbot @sHtev @loiswells97 @ArayB