Fixes spurious warning raised when initializing VectorCells objects. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atInABox-Lab#102. Reintroduced an equality check for raising a warning if value of self.n was passed, but is reset internally in a VectorCells class. Equality is checked if `cell_arrangement` does not end in `"manifold"` (i.e., `"diverging_manifold"` or `"uniform_manifold"`. If `cell_arrangement` is `"random"` or a callable function, a warning is only raised if the value of self.n would actually change.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mistake I introduced in PR #101, raised in issue #102:
cell_arrangementdoes not end in"manifold"cell_arrangementis a callable function (or"random"), a warning is only raised if the value ofself.nwould actually change.cell_arrangementis"diverging_manifold"or"uniform_manifold", a warning is raised even if the value ofnthat was passed happens to match the one calculated internally.