Fixed incorrect scaling of BVCs firingrates I#108. #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108.
Added a line when
self.cell_fr_norm
is initialized in the BVCs to unscale it usingself.min_fr
andself.max_fr
.BVCs now generate firingrates spanning the full range expected with
min_fr
andmax_fr
.Note: The small overshoot above
max_fr
mentioned in the issue is not addressed here.