Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make save folders year first by default. #117

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

colleenjg
Copy link
Contributor

Changed default date formatting of utils.save_figure() to be year first ("%y_%m_%d") instead of day first ("%d_%m_%y").
Day first can be used by called save_figure() with year_first=False

@colleenjg
Copy link
Contributor Author

colleenjg commented Nov 7, 2024

Ok, following a quick discussion, I removed the option to set year_first=False and squashed the commit.

Note: Since this change changes folder names, it could transitionally cause some annoyance for users whose other code or directory structure expects "%d_%m_%y", when they start to get "%y_%m_%d" folders.

However, as discussed, the year first approach is probably better overall as it makes sorting by name chronological.

@TomGeorge1234 TomGeorge1234 merged commit 906aab5 into RatInABox-Lab:main Nov 8, 2024
3 checks passed
@TomGeorge1234
Copy link
Collaborator

the QOL update we never knew we needed. Thanks Colleen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants