Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible head direction #72

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

mehulrastogi
Copy link
Contributor

solves #70

@TomGeorge1234
Copy link
Collaborator

brilliant, I made a couple of minor tweaks; some warnings plus I think the head direction vector should be updated with the normalised velocity vector rather than straight-up velocity so its not biased in favour of faster speeds, thats all.

great job @mehulrastogi, thanks for a speedy update!

@TomGeorge1234 TomGeorge1234 merged commit 9572622 into RatInABox-Lab:dev Jul 18, 2023
@mehulrastogi
Copy link
Contributor Author

@TomGeorge1234 there is a typo in the last commit. Instead of warning.warn it should be warnings.warn

We should really set up the automatic tests. Want me to look into it?

@TomGeorge1234
Copy link
Collaborator

fixed. but you're right, this shouldn't happen, tests would be great actually, if you had time I'd really appreciate it!

@mehulrastogi mehulrastogi deleted the head-dir branch October 23, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants