Fixes an issue in the double peak filter #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rettier Thanks for your contribution! Sorry for the late response. I started a new position right before you made this pull request and my attention diverted away from GitHub. This makes sense and it probably explains why I've had issues with this filter in the past. There's a more functional refactor of this project in progress, so it will be good to have this working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript's sort sorts alphabetically by the string representation, resulting in seemingly random energies when small numbers are involved. This is because the string representation eventually changes to scientific notation.
This PR fixes it by passing a comparator.