Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[book 3][book1-review] Chapter 6 issues #1017

Closed
genmeblog opened this issue May 4, 2022 · 2 comments
Closed

[book 3][book1-review] Chapter 6 issues #1017

genmeblog opened this issue May 4, 2022 · 2 comments
Assignees
Milestone

Comments

@genmeblog
Copy link

genmeblog commented May 4, 2022

I go through The Rest of Your Life in version 4.x

First two images from Chapter 2.3 "Stratified Samples (Jittering)" created from my code are identical as in the book. The next changes are in Chapter 6.

Chapter 6.1 changes two things: samples_per_pixel are set to 100 (changed from 64) and scattering_pdf is introduced (it doesn't matter in this chapter since scattering_pdf/pdf = 1. The Image 3 contains very low noise and from my experiments similar result can be achieved by setting samples_per_pixel to 1000 (not 100 as in the book).

Chapter 6.2 sets pdf to a constant, and again, Image 4 is far for the result I've got.

I know that images are going to be recreated - just wanted to emphasize it here.

Chapter 6.3 sets scattering_pdf to a constant, which with connection to a line from previous chapters (ie. double pdf = scattering_pdf;), again, gives ratio scattering_pdf/pdf=1. This degenerates to a hemisphere scattering from book1.

Is it correct?

@hollasch
Copy link
Collaborator

hollasch commented May 4, 2022

Will review.

@hollasch hollasch self-assigned this May 4, 2022
@hollasch hollasch added this to the v4.0.0-rel milestone May 4, 2022
@hollasch hollasch modified the milestones: v4.0.0-rel, v4.0.0-books23 Jun 19, 2023
@hollasch hollasch modified the milestones: v4.0.0-book3, v4.0.0 Jul 20, 2023
@hollasch
Copy link
Collaborator

This is two issues mixed together. First is dupe of #1018. Second is described in more detail in #1302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants