Skip to content

[The Rest of Your Life] Listing 1 low noise #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hollasch opened this issue May 4, 2022 Discussed in #1016 · 0 comments
Closed

[The Rest of Your Life] Listing 1 low noise #1018

hollasch opened this issue May 4, 2022 Discussed in #1016 · 0 comments
Assignees
Milestone

Comments

@hollasch
Copy link
Collaborator

hollasch commented May 4, 2022

Discussed in #1016

Originally posted by genmeblog May 4, 2022
The image generated in listing 1 (or listing 3 in version 4.x) contains very low noise. My result however is quite noisy.

In book v.4, the only difference is samples_per_pixel set to 100 (instead of 64 from beginning of the book). It doesn't create such smooth image as here.
In book v.3, pdf can have negative values and the result is very noisy.

Book v4 version from my code:
ch06a

Is it bug in the book or in my code?

(samples_per_pixel set to 1000 gives the result similar to this from the book)

@hollasch hollasch added this to the v4.0.0-rel milestone May 4, 2022
@hollasch hollasch self-assigned this May 4, 2022
@hollasch hollasch modified the milestones: v4.0.0-rel, v4.0.0-books23 Jun 19, 2023
@hollasch hollasch modified the milestones: v4.0.0-book3, v4.0.0 Jul 20, 2023
hollasch added a commit that referenced this issue Mar 27, 2024
hollasch added a commit that referenced this issue Apr 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Use math markup in captions for book 3. Book 2 already does this.

Remove unnecessary includes

Move setprecision call for consistency. This keeps the call in the same
location across multiple versions of pi.cc.

Update Listing 3.03 with change highlighting

Update Listing 3.04, 3.06, 3.12, 3.14, 3.15, 3.17, 3.18, 3.22, 3.24,
3.26

Clean up listing 3.07 pi.cc alternate version one

Update Listing 3.08 and following text

Update listing 3.13 Explicit uniform PDF for x^2

Update listing 3.16
  - Add missing includes
  - Add precise decimal value of expected result

Fix equation text in section 8.2

Update listing 3.28; code is broken at this point

This fixes the lack of `material::scatter()` signature change in the
`material` base class, but still lacks the corresponding changes
required in metal, dielectric, diffuse_light and isotropic materials. In
addition, it lacks the change required to the `camera::ray_color()`
function call to `material::scatter()`.

sphere_plot.cc: Fix iteration count

Resolves #1018
Resolves #1312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant