Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 3.6.2: Need for clarification about the resulting render when using an imperfect PDF #1321

Open
Shridhar2602 opened this issue Oct 28, 2023 · 2 comments
Assignees
Milestone

Comments

@Shridhar2602
Copy link

Shridhar2602 commented Oct 28, 2023

In section 6.2, "Using a Uniform PDF Instead of a Perfect Match", there's a need for clarification to avoid confusion.
The section currently states -

This will still converge on the correct answer, as all we've done is change the PDF, but since the PDF is now less of a perfect match for the real distribution, it will take longer to converge. Which, for the same number of samples means a noisier image:
....
You should get a very similar result to before, only with slightly more noise, it may be hard to see.

In my implementation, I am getting a much brighter image after changing the PDF to uniform, which as per my knowledge is the expected behavior. While the section does mention increased noise, it doesn't adequately address the potential issue of a brighter or dimmer rendered image. This omission can be frustrating for beginners, who would expect to see a slightly noisy image but would instead get a drastically different render after changing the pdf.

Or am I mistaken and going wrong somewhere?

@hollasch hollasch added this to the v4.0.0 milestone Oct 28, 2023
@gau-nernst
Copy link

I observed the same problem. From my understanding, the problem is related to #933. Not sure why it was fixed in v3 but v4 has the wrong implementation. Basically, the sampling PDF and scattered ray should be linked. We cannot change the sampling PDF (pdf in the code) without changing how the scattered ray is sampled.

@hollasch hollasch changed the title [Book 3 : Section 6.2] Need for clarification about the resulting render when using an imperfect PDF Book 3.6.2: Need for clarification about the resulting render when using an imperfect PDF Apr 19, 2024
@dimitry-ishenko
Copy link
Contributor

Related to #1302

@hollasch hollasch modified the milestones: v4.0.0, Backlog, v4.1.0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants