Progression 3 updates #1462
Merged
Progression 3 updates #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the call in the same location across multiple versions of pi.cc.
- Add missing includes - Add precise decimal value of expected result
Resolves #1018
This fixes the lack of `material::scatter()` signature change in the `material` base class, but still lacks the corresponding changes required in metal, dielectric, diffuse_light and isotropic materials. In addition, it lacks the change required to the `camera::ray_color()` function call to `material::scatter()`. Resolves #1312
|
Here's a reminder when going through these potato chip changes that on GitHub while reviewing a commit, |
|
Oh, by the way, the corresponding book 3 progression for this batch is from |
rupsis
approved these changes
Apr 2, 2024
| @@ -457,27 +473,19 @@ | |||
|
|
|||
| <div class='together'> | |||
| Our work above is equally valid as a means to solve for $pi$ as it is a means to solve for the area | |||
There was a problem hiding this comment.
Shouldn't this be $\pi$ instead of $pi$ ?
Book 2 already does this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slew of changes from the book 3 progression up to listing 28. Listing 28 leaves us in a broken state, covered in issues #1302, #1321.