Skip to content

733: bvh_node breaking with negative-radius spheres #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

733: bvh_node breaking with negative-radius spheres #785

wants to merge 1 commit into from

Conversation

define-private-public
Copy link

Fix is to make sure that the AABB's is always a positive real number it
should never be negative.

Closes #733

@define-private-public
733: bvh_node breaking with negative-radius spheres
64e9072 
Fix is to make sure that the AABB's is always a positive real number it
should never be negative.

Closes RayTracing#733
@hollasch hollasch self-requested a review October 30, 2020 02:23
@hollasch
Copy link
Collaborator

hollasch commented Oct 31, 2020 •
edited
Loading

Are you open to making the change above to aabb? If so, let's see if that fixes your problem. We'll need to retarget this to dev-major at this point. I'm also willing to do this if you'd like.

@define-private-public
Copy link
Author

It's on my TODO to try out the AABB-proofing method as you suggested.

@define-private-public
Copy link
Author

Sorry, I haven't gotten around to this yet. I've been busy with other tasks. You can reject this this PR if you want; I don't think I'm going to get around this soon.

@hollasch
Copy link
Collaborator

Ok, thanks for the clear hand-off. I'm tackling a bunch of big refactorings, so I'll just add this to my list. I'll leave this open for now to remind me, and would appreciate review feedback when I get to it.

@hollasch hollasch self-assigned this Nov 17, 2020
@hollasch
Copy link
Collaborator

See #812

@hollasch
Copy link
Collaborator

@define-private-public — Hopefully addressed in #812. Let me know if this doesn't work for your scenario.

@hollasch hollasch closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollasch hollasch Awaiting requested review from hollasch

Assignees

@hollasch hollasch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bvh_node is broken with negative-radius spheres
2 participants
@define-private-public @hollasch