Skip to content

Commit

Permalink
Pass default certs to SNICallback example
Browse files Browse the repository at this point in the history
Using only SNICallback to create a HTTPS / TLS server is bad. It means all non SNI clients can't do anything because there are no certs.

in v0.10 of node TLS server was updated to throw if you forgot to supply certs.

Which means that every HTTPS server needs to supply certs as a fallback for when SNI is not available.

 - closes http-party#399
  • Loading branch information
Raynos committed May 10, 2013
1 parent de0928f commit f5e1844
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,10 @@ var options = {
https: {
SNICallback: function (hostname) {
return certs[hostname];
}
},
cert: myCert,
key: myKey,
ca: [myCa]
},
hostnameOnly: true,
router: {
Expand Down

0 comments on commit f5e1844

Please sign in to comment.