Stop using deprecated or unmaintained CI dependencies #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `macos-10.15` image is deprecated and will be removed by 2022-08-30 [1]. It would be possible to pin CI to `macos-11` or `macos-12`, but relying on `-latest` is unlikely to cause problems and avoids having to update the workflow for this again. While at it, also switch to `windows-latest` and `ubuntu-latest`. Note that `-latest` are the latest stable images that GitHub provides, and might not be the most recent version of the operating system available from the operating system vendor. As of this writing this effectively updates: macos-10.15 -> macos-11 windows-2019 -> windows-2022 (ubuntu remains unchanged at 20.04) [1] https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
The actions-rs organization is unmaintained with the sole member being unresponsive for close to two years. Use `dtolnay/rust-toolchain` instead of `actions-rs/toolchain`.
Currently this jobs relies on whatever is provided by the underlying image, which may or may not be latest stable Rust.
This is mostly done for consistency with the other jobs. However, it does have the advantage of disabling incremental compilation, which should slightly speed up compilation since CI only does full builds.
Currently this job relies on whatever is provided by the underlying image, which may or may not have these components installed and up-to-date.
Closed
adamreichold
approved these changes
Aug 26, 2022
|
Since when |
|
As mentioned in the description, it's unmaintained for almost two years at this point. See actions-rs/toolchain#216 for some discussion. |
|
Ok, seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two big items here are:
macos-10.15is deprecated by GitHub actions and will be removed by 2022-08-30, which is in 4 days. Switch all runner images to their-latestversion, so this won't be a concern again in the foreseeable future.dtolnay/rust-toolchain.Best reviewed commit-by-commit.
The update of
actions/checkoutto v3 has been intentionally left out here. Instead of doing a one-time bump, I'll submit a separate PR adding a dependabot config to keep watch over that going forward.