-
-
Notifications
You must be signed in to change notification settings - Fork 218
Rcpp compilation issue on Alpine distribution #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would encourage you to work up a (minimal) pull request demonstrating (via Travis CI) that nothing breaks on other systems yet that it recognizes your (somewhat exotic) libc variant. We generally rely on that set of defines list over here at sourceforge. Methinks the required change may just be on one line (but possibly one line in several files). |
From musl source code (http://git.musl-libc.org/cgit/musl/tree/include), there seems no I know GLIBC defines several macros (https://github.com/lattera/glibc/blob/master/include/features.h#L358), so we know we are using GLIBC. I am not sure there are such macros in musl. |
@thirdwing take a step back -- @lostie correctly pointed to line 40 for |
I don't seem to be able to push my changes to the remote 😢 Here's a suggested patch: https://gist.github.com/lostie/425d11dff9c06cc9ff89 |
Welcome to git(hub). You are supposed to fork a repo after which you can push to your copy after which you can (once happy) propose a pull request back to our repo. Which we, who have write access to our repo, may or may not accept. There are lots of tutorials for all of this. |
This was taken care of in #449. |
I still have this issue with Rcpp 0.12.5
|
@albap Hi, you need to modify the Makevars first. |
@thirdwing |
You need You can add the following line
into Makevars (https://github.com/RcppCore/Rcpp/blob/master/src/Makevars) in the package. |
So I can't just install.package("ggplot2") (and maybe other packages) on Alpine? |
You can try with a
|
@thirdwing 's suggestion is what I would do but possibly with
to ensure C++ and C++11 have it set. That will affect all R builds across all packages; and at least Rcpp should take advantage of it. |
Can we set it in system-wide |
Not everyone has the permission to change system-wide configurations. |
Basically, when Reading the file at |
That’s not what I’ve asked. I’m maintainer of the R package in Alpine Linux, so I’m about to add @kevinushey, thanks, so I’m gonna add these to the |
@albap @jirutka: 📝 This change now exists in each of the Alpine packages for R which I maintain - https://github.com/sgerrand/alpine-pkg-R/releases. I've updated the value of Try it out:
|
Thanks for the update. As it happens, we'll probably release a new Rcpp version within a few days so if you have some cycles to spare, could you try the current master branch here (with version 0.12.5.7 likely to become 0.12.6 'real soon now') ? |
@sgerrand I wonder, why do you maintain sgerrand/alpine-pkg-R when we already have R package in official Alpine repository? |
Mainly because that package predated my packaging efforts, it is still only |
This is all getting a little too inside-baseball for Rcpp so I am going to lock this discussion here. As it stands, Rcpp appears to be twice compiled right for Alpine we're all a happy family now. |
It seems related to #360 (although on a diferrent platform).
The code it is hitting seems to be https://github.com/RcppCore/Rcpp/blob/0.12.3/src/api.cpp#L40
According to the gnulib page it seems that for platforms that the file is missing it should only have a stub (do nothing).
Alpine seems to use a different
libc
as mentioned aboveIs that the Alpine distribution be covered by the
Rcpp api.cpp
to just use a stub?The text was updated successfully, but these errors were encountered: