remove erroneous PreserveObject call in String::wrap #1082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1081.
This PR fixes an issue where
String::wrap()
would un-necessarily callRcpp_PreserveObject()
, thereby 'leaking' the SEXP returned to R (basically, not allowing the R GC to ever collect that object).Unfortunately it doesn't fix #1081 but I do think it's at least part of the issue.
Checklist
R CMD check
still passes all tests