Generalized a test which had adjusted to a (temporary) R-devel issue (closes #1397) #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR generalizes a test that was previously adjusted for a temporary R-devel issue with row and column means over complex data containing NA values. The temporary workaround is being removed since R-devel has fixed the underlying issue.
- Removes R version-specific conditional logic from complex matrix tests
- Updates package micro version from 1.1.0.3 to 1.1.0.4 and date to 2025-10-13
- Adds changelog entry documenting the test simplification
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| inst/tinytest/test_sugar.R | Removes R version conditionals and keeps both original and apply-based test variants |
| inst/include/Rcpp/config.h | Updates development version numbers to 1.1.0.4 |
| DESCRIPTION | Updates package version and date |
| ChangeLog | Documents the test generalization and version bump |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Belated LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 79ba459 adjusted for (temporary) glitch in R-devel dealing with row and col means over complex data where only one of real and imaginary is
NA. This has been addressed in R-devel so we no longer need to special-case it, and as an added bonus we keep the addedapply()based variant.We also rolled the micro release version and date,
Checklist
R CMD checkstill passes all tests