Get rid of TBB_INTERFACE_NEW macro #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TBB_INTERFACE_NEW` macro was introduced to check the new TBB interface, whcih is not needed anymore. We can generally use `__TBB_tbb_stddef_H` macro that is defined by `tbb/tbb_stddef.h` and is removed in the new interface, This reverts commit f971883.
|
Should we keep that around anyway, for compatibility with older versions of TBB (on older platforms)? |
It won't hurt if we keep it. Though, I introduced it in #141 and stan-dev/math#2257 and it won't exist anywhere after stan-dev/math#2261. |
|
@kevinushey After thinking about this, I agree with you that it might be better to keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBB_INTERFACE_NEWmacro was introduced to check the new TBB interface,whcih is not needed anymore. We can generally use
__TBB_tbb_stddef_Hmacrothat is defined by
tbb/tbb_stddef.hand is removed in the new interface,This reverts commit f971883.