Skip to content

Commit

Permalink
removed -g from rel-cran to reduce datatable.so from 1.5MB to 0.5MB a…
Browse files Browse the repository at this point in the history
…nd clear 'installed size > 5MB' note
  • Loading branch information
mattdowle committed May 4, 2019
1 parent b835a40 commit 7810b22
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ test-rel-cran-lin: # currently released R on Linux
variables:
_R_CHECK_CRAN_INCOMING_: "TRUE" # stricter --as-cran checks should run in dev pipelines continuously (not sure what they are though)
_R_CHECK_CRAN_INCOMING_REMOTE_: "FALSE" # Other than no URL checking (takes many minutes) or 'Days since last update 0' NOTEs needed, #3284
before_script:
- mkdir -p ~/.R
- echo 'CFLAGS=-O3'> ~/.R/Makevars # No -g because -g increases datatable.so size from 0.5MB to 1.5MB and breaches 'installed package size <= 5MB' note

This comment has been minimized.

Copy link
@jangorecki

jangorecki May 13, 2019

Member

@mattdowle could we remove -g and keep default -O2? we do test -O3 in test-rel-lin (the most comprehensive job) thus test-rel-cran-lin would be best to keep closer to default.

This comment has been minimized.

Copy link
@mattdowle

mattdowle May 13, 2019

Author Member
- echo 'CXXFLAGS=-O3' >> ~/.R/Makevars
script:
- Rscript -e 'source("ci.R"); install.packages(dcf.dependencies("DESCRIPTION", which="most"))'
- *copy-src
Expand Down

0 comments on commit 7810b22

Please sign in to comment.