Skip to content

Commit

Permalink
Attempt at fixing #1467, not resolved in current namespace error.
Browse files Browse the repository at this point in the history
  • Loading branch information
arunsrinivasan committed Feb 25, 2016
1 parent 44e1d13 commit b87c5c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions R/data.table.R
Original file line number Diff line number Diff line change
Expand Up @@ -2068,7 +2068,8 @@ na.omit.data.table <- function (object, cols = seq_along(object), invert = FALSE
}

which_ <- function(x, bool = TRUE) {
.Call("Cwhichwrapper", x, bool)
# fix for #1467, quotes result in "not resolved in current namespace" error
.Call(Cwhichwrapper, x, bool)
}

is.na.data.table <- function (x) {
Expand Down Expand Up @@ -2305,7 +2306,8 @@ rbindlist <- function(l, use.names=fill, fill=FALSE, idcol=NULL) {
if (!is.character(idcol)) stop("idcol must be a logical or character vector of length 1. If logical TRUE the id column will named '.id'.")
idcol = idcol[1L]
}
ans = .Call("Crbindlist", l, use.names, fill, idcol)
# fix for #1467, quotes result in "not resolved in current namespace" error
ans = .Call(Crbindlist, l, use.names, fill, idcol)
if (!length(ans)) return(null.data.table())
setDT(ans)[]
}
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@

27. `[.data.table` handles column subsets based on conditions that result in `NULL` as list elements correctly, [#1477](https://github.com/Rdatatable/data.table/issues/1477). Thanks @MichaelChirico. Also thanks to @Max from DSR for spotting a bug as a result of this fix. Now fixed.

28. Providing the first argument to `.Call`, for e.g., `.Call("Crbindlist", ...)` seems to result in *"not resolved in current namespace"* error. A potential fix is to simply remove the quotes like so many other calls in data.table. Potentially fixes [#1467](https://github.com/Rdatatable/data.table/issues/1467). Thanks to @rBatt, @rsaporta and @damienchallet.

#### NOTES

1. Updated error message on invalid joins to reflect the new `on=` syntax, [#1368](https://github.com/Rdatatable/data.table/issues/1368). Thanks @MichaelChirico.
Expand Down

0 comments on commit b87c5c1

Please sign in to comment.