Handled case when no secondary indices are set, #1479

Rdatatable · Mar 9, 2016 · fa9dca0 · fa9dca0
1 parent 6d751f6
commit fa9dca0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/R/data.table.R b/R/data.table.R
@@ -1720,9 +1720,11 @@ chmatch2 <- function(x, table, nomatch=NA_integer_) {
         # fixes #1479. Take care of secondary indices, TODO: cleaner way of doing this
         attrs = attr(x, 'index')
         skeys = names(attributes(attrs))
-        hits  = unlist(lapply(paste("__", names(x)[cols], sep=""), function(x) grep(x, skeys)))
-        hits  = skeys[unique(hits)]
-        for (i in seq_along(hits)) setattr(attrs, hits[i], NULL) # does by reference
+        if (!is.null(skeys)) {
+            hits  = unlist(lapply(paste("__", names(x)[cols], sep=""), function(x) grep(x, skeys)))
+            hits  = skeys[unique(hits)]
+            for (i in seq_along(hits)) setattr(attrs, hits[i], NULL) # does by reference
+        }
         if (!missing(keyby)) {
             cnames = as.character(bysubl)[-1]
             if (all(cnames %chin% names(x)))

diff --git a/inst/tests/tests.Rraw b/inst/tests/tests.Rraw
@@ -7887,6 +7887,8 @@ dt = data.table(a = rep(c(F,F,T,F,F,F,F,F,F), 3), b = c("x", "y", "z"))
 set2key(dt, b)
 dt[, a := as.logical(sum(a)), by = b]
 test(1632.2, names(attributes(attr(dt, 'index'))), "__b")
+dt = data.table(a = rep(c(F,F,T,F,F,F,F,F,F), 3), b = c("x", "y", "z"))
+test(1632.3, copy(dt)[, c := !a, by=b], copy(dt)[, c := c(T,T,F,T,T,T,T,T,T)])
 
 ##########################