Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few improvements to between.Rd #1521

Closed
3 tasks done
MichaelChirico opened this issue Feb 5, 2016 · 2 comments
Closed
3 tasks done

A few improvements to between.Rd #1521

MichaelChirico opened this issue Feb 5, 2016 · 2 comments
Labels
documentation enhancement
Milestone
v1.9.8

Comments

@MichaelChirico
Copy link
Member

  • Need to uncomment %.
  • Need to mention the default value of incbounds is TRUE for the x %between% y infix usage.
  • Clarifying valid x classes (since between doesn't work with, e.g., complex or factor vectors)
@MichaelChirico MichaelChirico changed the title Documentation typo in between.Rd A few improvements to between.Rd Feb 8, 2016
arunsrinivasan added a commit that referenced this issue Feb 8, 2016
@arunsrinivasan
Merge pull request #1522 from MichaelChirico/bw_man
af83025 
Closes #1521, fixes typo in between.Rd
@arunsrinivasan arunsrinivasan added this to the v1.9.8 milestone Feb 8, 2016
arunsrinivasan added a commit that referenced this issue Mar 5, 2016
@arunsrinivasan
Closes #1521, NAs in logical subsets are ignored also in DT[NA].
353cf8a
@MichaelChirico
Copy link
Member Author

Hey @arunsrinivasan I think you got the number wrong on this latest commit. This issue doesn't have to do with NAs in i....

@arunsrinivasan
Copy link
Member

Yes.. it's #1252. Made a note there..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
v1.9.8
Development

No branches or pull requests
2 participants
@arunsrinivasan @MichaelChirico