Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: ?wday should mention the reference day #1658

Closed
MichaelChirico opened this issue Apr 19, 2016 · 2 comments
Closed

Documentation: ?wday should mention the reference day #1658

MichaelChirico opened this issue Apr 19, 2016 · 2 comments
Labels
documentation

Comments

@MichaelChirico
Copy link
Member

MichaelChirico commented Apr 19, 2016 •
edited
Loading

The man page for ?wday needs to mention the reference day (Sunday) and expected output (1 through 7), especially since it is in conflict with ?POSIXlt:

wday(as.Date("2016-04-18"))
# [1] 2 
as.POSIXlt("2016-04-18")$wday
# [1] 1

A perfectly fine design choice, but this needs to be mentioned.
@arunsrinivasan
Copy link
Member

Sure, do you mind issuing a PR?

@MichaelChirico
Copy link
Member Author

planning on it :)

arunsrinivasan added a commit that referenced this issue Apr 20, 2016
@arunsrinivasan
Squashed commit of the following:
1ade3f5 
commit 1fbebc3b3803b274e80a9adad9ba9a4015898472
Author: arunsrinivasan <aragorn168b@gmail.com>
Date:   Wed Apr 20 22:12:56 2016 +0200

    PR #1663, fix for #1658 enhance doc on wday in ?IDateTime
@MichaelChirico MichaelChirico mentioned this issue Jul 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arunsrinivasan @jangorecki @MichaelChirico