-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as.xts.data.table does not properly support all date based classes for index #2408
Milestone
Comments
ethanbsmith
changed the title
as.xts.data.table doesnt support all date type index
as.xts.data.table does not properly support all date based classes for index
Oct 10, 2017
drop in replacement:
|
Nice catch! Feel free to file a PR, see Contribution Guidelines! happy to help facilitate |
i have fixes and test in https://github.com/ebs238/data.table. |
Can you attempt to pull into master please? it'll be easier for me to see
the output of Travis & help you out
On Oct 13, 2017 11:47 PM, "ebs238" <notifications@github.com> wrote:
i have fixes and test in https://github.com/ebs238/data.table.
The fix works and looks clean to me, but I cant get the test to pass, and
im not sure why.
This is my first attempt at a PR, so any suggestions would be appreciated
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2408 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHQQdWdY9v1qhe-O-1rvYXjTVvH0RBqcks5sr4YjgaJpZM4P0NCp>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xts objects support many date classes for the index, but the
as.xts
function only explicitly checks for small subset of classes.fortunately, the
xts::timeBased
function will perform this check properlyi.e. replace
if (!any((index_class <- class(x[[1L]])) %in% c("POSIXct", "Date")))
with:
if(!xts::timeBased(x[[1L]]))
The text was updated successfully, but these errors were encountered: