Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsum on int64 ignores na.rm=FALSE #3464

Closed
jangorecki opened this issue Mar 18, 2019 · 0 comments · Fixed by #3737
Closed

gsum on int64 ignores na.rm=FALSE #3464

jangorecki opened this issue Mar 18, 2019 · 0 comments · Fixed by #3737
Assignees
@jangorecki
Labels
bit64 GForce issues relating to optimized grouping calculations (GForce)
Milestone
1.12.4

Comments

@jangorecki
Copy link
Member 

DT = data.table(id=c(rep(1L,3), rep(2L, 3)), v=bit64::as.integer64(c(1:3, NA, 5:6)))
DT[2:6, sum(v), id]
#      id    V1
#   <int> <i64>
#1:     1     5
#2:     2    11
DT[, "v" := as.integer(v)]
#      id    V1
#   <int> <int>
#1:     1     5
#2:     2    NA

might be related to #1647
@jangorecki jangorecki added bit64 GForce issues relating to optimized grouping calculations (GForce) labels Mar 18, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone May 14, 2019
@jangorecki jangorecki self-assigned this Jul 31, 2019
jangorecki added a commit that referenced this issue Jul 31, 2019
@jangorecki
gsum works on int64 column, closes #1647 #3464
0b5d251
@jangorecki jangorecki mentioned this issue Jul 31, 2019
Merged
mattdowle pushed a commit that referenced this issue Aug 14, 2019
@jangorecki @mattdowle
gsum works on int64 column, closes #1647 #3464 (#3737)
a8e926a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangorecki jangorecki

Labels
bit64 GForce issues relating to optimized grouping calculations (GForce)
Projects
None yet
Milestone
1.12.4
Development

Successfully merging a pull request may close this issue.

gsum works on int64 column, closes #1647 #3464 Rdatatable/data.table
2 participants
@mattdowle @jangorecki