Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-devel changed error message breaks 1199.2 #4769

Closed
jangorecki opened this issue Oct 21, 2020 · 0 comments · Fixed by #4770
Closed

R-devel changed error message breaks 1199.2 #4769

jangorecki opened this issue Oct 21, 2020 · 0 comments · Fixed by #4770
Assignees
Labels
Milestone

Comments

@jangorecki
Copy link
Member

jangorecki commented Oct 21, 2020

Recent release 1.13.2 of data.table was nicely passing cran checks for a couple of hours: https://cran.r-project.org/web/checks/check_results_data.table.html
15 hours ago there was a commit to R wch/r-source@138a8c5 that broke test 1199.2.
My suggestion is to fix it for 1.13.4 and submit straight away to CRAN, so no need for revdeps, ASAN checks. Actually it is not that urgent as any code isn't actually broken. Unit test was against base R. Revdeps and users are not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant