Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vignettes avoid max.print #5783

Closed
jangorecki opened this issue Dec 2, 2023 · 2 comments · Fixed by #5784
Closed

vignettes avoid max.print #5783

jangorecki opened this issue Dec 2, 2023 · 2 comments · Fixed by #5784
Assignees
@jangorecki
Milestone
1.15.0

Comments

@jangorecki
Copy link
Member

New vignette added in (to be) 1.14.99 uses options(max.print = ...). As a side effect, all vignettes, that are being rendered after that one, are inheriting this options, and it gets messy. See https://jangorecki.github.io/armarkdown/rmarkdown/datatable-reference-semantics.html
@jangorecki jangorecki added this to the 1.15.0 milestone Dec 2, 2023
@jangorecki jangorecki self-assigned this Dec 2, 2023
jangorecki added a commit that referenced this issue Dec 2, 2023
@jangorecki
do not use options max.print in vignettes, closes #5783
96837ec
@jangorecki jangorecki mentioned this issue Dec 2, 2023
Merged
2 tasks
@MichaelChirico
Copy link
Member

New vignette added in (to be) 1.14.99 uses options(max.print = ...). As a side effect, all vignettes, that are being rendered after that one, are inheriting this options, and it gets messy. See https://jangorecki.github.io/armarkdown/rmarkdown/datatable-reference-semantics.html

is this documented behavior (options() persisting across rendering all vignettes)?

(approach in #5784 is preferable anyway, but maybe this is an R bug)

@jangorecki
Copy link
Member Author

no idea, I am not digging that deep :D

jangorecki added a commit that referenced this issue Dec 3, 2023
@jangorecki
followup vignettes updated after change to markdown vignette engine (#…
c3ad47d 
…5784)

* do not use options max.print in vignettes, closes #5783

* follow up of markdown vign enginge #5773

* amend feedback from Michael
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangorecki jangorecki

Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging a pull request may close this issue.

followup vignettes updated after change to markdown vignette engine Rdatatable/data.table
2 participants
@jangorecki @MichaelChirico