Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank line from description (breaks install with packrat) #1202

Merged

Conversation

ysgit
Copy link

@ysgit ysgit commented Jun 30, 2015

This prevents data.table from working with packrat

Previously done in #1118

@arunsrinivasan
Copy link
Member

Thanks, but already taken care of in #1118

@ysgit
Copy link
Author

ysgit commented Aug 3, 2015

@arunsrinivasan that's true but following #1118 the blank line came back in 3afd98e, currently install with packrat does not work.

@mattdowle
Copy link
Member

Reopened thanks @ysgit.
But surely it's a pakrat issue. It isn't even a blank line, it's just a \n after the last line of text, as completely normal in text files. Has it been raised with them?

@mattdowle mattdowle reopened this Aug 5, 2015
mattdowle added a commit that referenced this pull request Aug 5, 2015
Remove blank line from description (breaks install with packrat)
@mattdowle mattdowle merged commit 7074faa into Rdatatable:master Aug 5, 2015
@ysgit
Copy link
Author

ysgit commented Aug 5, 2015

Thanks @mattdowle this is actually as issue with devtools::install_github - see r-lib/devtools#383 and r-lib/devtools#394. From what I understand a training blank line doesn't cause a problem but a blank line between fields does. What packrat does is append some lines to the description file so if there is a trailing blank line in the description this will become a trailing blank line. In any case, I've opened an issue with rstudio/packrat#237

@mattdowle
Copy link
Member

Great. Thanks @ysgit .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants