Closes #1765 -- new isoweek function produces ISO 8601-consistent week numbering as an integer #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k numbering as an integer fix man
Current coverage is 89.26% (diff: 100%)@@ master #1829 diff @@
==========================================
Files 58 58
Lines 10616 10620 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 9481 9480 -1
- Misses 1135 1140 +5
Partials 0 0
|
|
The next release will most likely have internal (efficient) implementations. So yes, better to have R versions for now.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few notes:
isoyearas well?as.POSIXlttwice, butlubridate::isoweekdoes the same essentially. Could maybe get away with doing some direct manipulation of thePOSIXltlist elements, but things are complicated since we can't add/subtract fromPOSIXltobjects.Idifftimeclass? Related as well to Completing the roster of .IDate methods with companion .Date methods #1695...