Add configurable parameter nSamplingPoints to fread(), #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work-around for occasional cases when default number of jump points is too high, causing overlap among sampled points. Closes #2157
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
=========================================
- Coverage 90.7% 90.7% -0.01%
=========================================
Files 59 59
Lines 11433 11441 +8
=========================================
+ Hits 10370 10377 +7
- Misses 1063 1064 +1
Continue to review full report at Codecov.
|
|
Fixed the error in 57c056f so the workaround parameter isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which provides work-around for occasional cases when default number of jump points is too high, causing overlap among sampled regions. Closes #2157