-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] clarifies 'in C-locale' #2387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
+ Coverage 91.24% 91.29% +0.05%
==========================================
Files 62 62
Lines 11978 11978
==========================================
+ Hits 10929 10935 +6
+ Misses 1049 1043 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's not exactly true. I have in mind users for whom neither C nor R locales are English. Maybe worth clarifying ("commonly"/"in English locales"/etc)
@HughParsonage This is great! I started a quick edit and it ended up being quite an expansion. Please could you check it before I pull and merge. I'll wait for you. @MichaelChirico I'll wait for you too since you commented above. |
I decided to put this part in Details as Matt's extra additions were important but a bit too lengthy for the Description (you couldn't see the Usage section with it in). Also meant this part of the documentation could use less abbreviated language and hence be a bit clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Yep - great! |
Adds a sentence to
man/setorder.Rd
to close #1996.