Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow bugfix #2405

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Shallow bugfix #2405

merged 2 commits into from
Oct 9, 2017

Conversation

MarkusBonsch
Copy link
Contributor

Closes #2336 by changing the behaviour of .shallow as follows:

  • if not all columns of a secondary index are copied and the index has length(idx) > 0, drop it to avoid spurious reordering.
  • if the index has length(idx) == 0, retain it for all columns until the first non-existing (exclusive)

@codecov-io
Copy link

codecov-io commented Oct 6, 2017

Codecov Report

Merging #2405 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2405      +/-   ##
=========================================
+ Coverage   91.29%   91.3%   +<.01%     
=========================================
  Files          62      62              
  Lines       12025   12027       +2     
=========================================
+ Hits        10978   10981       +3     
+ Misses       1047    1046       -1
Impacted Files Coverage Δ
R/data.table.R 97.45% <100%> (ø) ⬆️
src/rbindlist.c 88.93% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0375cfa...3b45e43. Read the comment docs.

@mattdowle mattdowle merged commit c6afa8c into master Oct 9, 2017
@mattdowle mattdowle deleted the shallow_bugfix branch October 9, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants