Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non equi issue 2360 fix #2461

Merged
merged 6 commits into from
Nov 8, 2017
Merged

Non equi issue 2360 fix #2461

merged 6 commits into from
Nov 8, 2017

Conversation

arunsrinivasan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 3, 2017

Codecov Report

Merging #2461 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
+ Coverage   91.58%   91.58%   +<.01%     
==========================================
  Files          62       63       +1     
  Lines       12028    12029       +1     
==========================================
+ Hits        11016    11017       +1     
  Misses       1012     1012
Impacted Files Coverage Δ
src/uniqlist.c 94.4% <ø> (-0.6%) ⬇️
src/init.c 93.1% <ø> (ø) ⬆️
R/data.table.R 97.16% <100%> (ø) ⬆️
src/nqrecreateindices.c 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa0a96...ca7ab74. Read the comment docs.

@Rdatatable Rdatatable deleted a comment from arunsrinivasan Nov 8, 2017
@mattdowle
Copy link
Member

I always wondered if deleting someone else's comment was possible. It seems it is but GitHub notes the delete it in the log which is good (unlike edits we can make to other people's comments without any apparent log). Arun's comment just said "not yet ready" but I knew it was as we had discussed, in case anyone was wondering what was deleted : - )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants