Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJ fails with proper error msg #2641

Merged
merged 7 commits into from
Feb 28, 2018
Merged

CJ fails with proper error msg #2641

merged 7 commits into from
Feb 28, 2018

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Feb 23, 2018

Closes #2636

@MichaelChirico
Copy link
Member

MichaelChirico commented Feb 23, 2018

I would make the error message more helpful to users, e.g.

stop("Input would result in ", nrow, " rows, which exceeds ", 
     .Machine$integer.max, ", the largest storable integer on this machine ",
     "(as dictated by '.Machine$integer.max').")

@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #2641 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
+ Coverage   93.16%   93.17%   +<.01%     
==========================================
  Files          61       61              
  Lines       12166    12169       +3     
==========================================
+ Hits        11335    11338       +3     
  Misses        831      831
Impacted Files Coverage Δ
R/setkey.R 93.86% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807f254...f9f6d3c. Read the comment docs.

@mattdowle mattdowle changed the title CJ fails with proper error msg. Closes #2636 CJ fails with proper error msg Feb 23, 2018
@mattdowle mattdowle added this to the v1.10.6 milestone Feb 28, 2018
Copy link
Member

@mattdowle mattdowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@mattdowle mattdowle merged commit e74eb7d into master Feb 28, 2018
@mattdowle mattdowle deleted the CJ_err_msg branch February 28, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants