Closes #1947, exception for gmin/gmax not to fail on ordered factors #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangorecki
reviewed
Jun 20, 2018
NEWS.md
Outdated
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| #### BUG FIXES | |||
|
|
|||
| 1. `gmin` and `gmax` no longer fail on _ordered_ factors, for which these operations are indeed meaningful, [#1947](https://github.com/Rdatatable/data.table/issues/1947#issuecomment-398212372). Thanks to @mcieslik-mctp for identifying and @mbacou for the nudge. | |||
There was a problem hiding this comment.
link to issue is enough, don't need to link particular comment :)
inst/tests/tests.Rraw
Outdated
| old_optim = options(datatable.optimize = Inf) | ||
| test(1914.5, DT[ , min(V1), by = V2], | ||
| data.table( | ||
| V2 = c("c", "d", "e", "f"), |
There was a problem hiding this comment.
In both GForce tests you used distinct values to group by in V2 field, which is somehow an edge case when grouping. In case of min/max then it is simply "as is" for each group. Would be a little bit safer to have GForce tests with 3 rows matching same group, so min/max on those is actually tested.
There was a problem hiding this comment.
OK, just copy-pasted the example from the issue, will make a more careful one.
There was a problem hiding this comment.
@MichaelChirico nice catch/fix. If you can ping me when you've added the test you'd like to, I'd be happy to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1947 I'm kind of surprised how easy this fix was.