backport trimws #3114
Merged
backport trimws #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,12 @@ | |||
|
|
|||
| if (!exists("trimws", "package:base")) { | |||
There was a problem hiding this comment.
better as
with(R.version, sprintf('%s.%s', major, minor)) >= '3.2.0'
?
There was a problem hiding this comment.
You mean if (getRversion() >= '3.2.0') I think. The comparison method for the package_version class does the right thing. But see comments in onLoad.R about why we don't switch on version number, but functionality instead. So much so that getRversion() is redefined to be stop() internally as a reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently failing tests under R 3.1.0, thanks to extended-CI.
(
trimwsis used inci.Randpublish.Rtoo but those scripts are in root only not the package.)