Improves diagnostic messaging of .SDcols when passed bad data #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bad data force NA character
MichaelChirico
force-pushed
the
SD_mismitch
branch
from
694b805 to
56a9027
Compare
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
==========================================
+ Coverage 91.96% 92.05% +0.09%
==========================================
Files 61 61
Lines 11444 11450 +6
==========================================
+ Hits 10524 10540 +16
+ Misses 920 910 -10
Continue to review full report at Codecov.
|
|
Please put "closes #num" in the body, not in the title. |
mattdowle
changed the title
|
Looks like a true fail in R-devel on length comparison. Will leave to you to fix. |
added 2 commits
October 19, 2018 12:02
MichaelChirico
force-pushed
the
SD_mismitch
branch
3 times, most recently
from
9c11621 to
0033f6c
Compare
fix warn not err fix again
MichaelChirico
force-pushed
the
SD_mismitch
branch
from
0033f6c to
a43cbee
Compare
|
@mattdowle finally got all the issues sorted out & managed to cover a bunch of new stuff in tests as well. ready to merge |
… Many times I don't look at the detail of long error messages and I like them to be over on the right off the screen. If I need to look at the detail I scroll over. Expanding statements vertically gets in the way of the logic, imo.
|
Great PR! Not least the coverage increase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3116
Closes #3118
Also added
brackifyhelper function. Might consider using it wherevercollapse = ', '-style error messages are used now...