Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new _type_ argument to update.dev.pkg #3150

Merged
merged 3 commits into from
Dec 5, 2018
Merged

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Nov 17, 2018

Closes #3148

@codecov
Copy link

codecov bot commented Nov 17, 2018

Codecov Report

Merging #3150 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3150      +/-   ##
==========================================
+ Coverage   92.05%   92.34%   +0.28%     
==========================================
  Files          61       61              
  Lines       11450    11582     +132     
==========================================
+ Hits        10540    10695     +155     
+ Misses        910      887      -23
Impacted Files Coverage Δ
src/reorder.c 97.43% <0%> (-0.24%) ⬇️
src/assign.c 94.57% <0%> (-0.17%) ⬇️
R/data.table.R 92.74% <0%> (ø) ⬆️
src/fread.c 98.34% <0%> (ø) ⬆️
R/as.data.table.R 94.87% <0%> (+0.04%) ⬆️
src/fsort.c 74.25% <0%> (+0.15%) ⬆️
src/forder.c 99.71% <0%> (+0.77%) ⬆️
R/groupingsets.R 84.26% <0%> (+1.51%) ⬆️
src/subset.c 100% <0%> (+2.74%) ⬆️
R/between.R 100% <0%> (+3.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55168ed...697f2e2. Read the comment docs.

@mattdowle mattdowle changed the title new _type_ argument to update.dev.pkg, closes #3148 new _type_ argument to update.dev.pkg Dec 5, 2018
@mattdowle mattdowle added this to the 1.12.0 milestone Dec 5, 2018
@mattdowle mattdowle merged commit a6ace8b into master Dec 5, 2018
@mattdowle mattdowle deleted the update-dev-pkg-type branch December 5, 2018 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants