Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groupingsets edge case for const j fix #3174

Merged
merged 2 commits into from
Dec 5, 2018
Merged

groupingsets edge case for const j fix #3174

merged 2 commits into from
Dec 5, 2018

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Dec 1, 2018 •
edited by mattdowle
Loading

Closes #3173

@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #3174 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   92.21%   92.22%   +<.01%     
==========================================
  Files          61       61              
  Lines       11579    11581       +2     
==========================================
+ Hits        10678    10681       +3     
+ Misses        901      900       -1
Impacted Files Coverage Δ
R/groupingsets.R 84.26% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65dfd4...ed8194c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 1, 2018 •
edited
Loading

Codecov Report

Merging #3174 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3174      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +<.01%     
==========================================
  Files          61       61              
  Lines       11578    11580       +2     
==========================================
+ Hits        10690    10693       +3     
+ Misses        888      887       -1
Impacted Files Coverage Δ
R/groupingsets.R 84.26% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d91eed...5088373. Read the comment docs.

MichaelChirico pushed a commit that referenced this pull request Dec 1, 2018
Drop test of bug given #3173, #3174
491b201
@mattdowle mattdowle changed the title groupingsets edge case for const j fix, closes #3173 groupingsets edge case for const j fix Dec 5, 2018
@mattdowle mattdowle added this to the 1.12.0 milestone Dec 5, 2018
@mattdowle mattdowle merged commit a3dafe3 into master Dec 5, 2018
@mattdowle mattdowle deleted the groupingsets-no-by-const-j branch December 5, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jangorecki @mattdowle