Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty .SDcols back to 1.11.8 behaviour, plus fix for integer() #3238

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

mattdowle
Copy link
Member

Closes #1789
Follow up to #3185
Fixes regression in dev before release reported by Kun Ren in comments in #3211

@mattdowle mattdowle added this to the 1.12.0 milestone Dec 20, 2018
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #3238 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   94.65%   94.64%   -0.01%     
==========================================
  Files          65       65              
  Lines       12100    12099       -1     
==========================================
- Hits        11453    11451       -2     
- Misses        647      648       +1
Impacted Files Coverage Δ
R/data.table.R 95.18% <100%> (-0.01%) ⬇️
src/uniqlist.c 95% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bac25...1c08f39. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #3238 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   94.65%   94.65%   -0.01%     
==========================================
  Files          65       65              
  Lines       12100    12099       -1     
==========================================
- Hits        11453    11452       -1     
  Misses        647      647
Impacted Files Coverage Δ
R/data.table.R 95.18% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bac25...1c08f39. Read the comment docs.

@MichaelChirico
Copy link
Member

always prefer to have more robustness!! thanks @kunren!!

@mattdowle mattdowle merged commit 022f586 into master Dec 20, 2018
@mattdowle mattdowle deleted the emptySD branch December 20, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants