rownames .SD #3254
Merged
rownames .SD #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
+ Coverage 94.65% 94.65% +<.01%
==========================================
Files 65 65
Lines 12105 12106 +1
==========================================
+ Hits 11458 11459 +1
Misses 647 647
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3254 +/- ##
==========================================
+ Coverage 94.65% 94.65% +<.01%
==========================================
Files 65 65
Lines 12105 12106 +1
==========================================
+ Hits 11458 11459 +1
Misses 647 647
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to revdep checking of package
rENA. Very rare case whererownames(.SD)are used; e.g.as.matrix(.SD)by group together with using.SDcolstoo and also using a column insidej={ }which is not in.SDcols. Problem arose in dev and not with CRAN version.Separately, a one-line change is needed to rENA in one test, for reference from #3233.
I emailed rENA maintainer as follows :
Dear Cody,
Firstly, happy new year!
data.table v1.12.0 is about to go to CRAN and revdep checking shows it will break rENA.
This change affects rENA :
Please change line 105 of tests/testthat/test.ena.accumulate.data.file.R from :
testthat::expect_identical(x$adjacency.vectors, xtest[,grep("^adjacency", colnames(xtest)), with=F])to
testthat::expect_equal(x$adjacency.vectors, xtest[,grep("^adjacency", colnames(xtest)), with=F], check.attributes=FALSE)I've checked rENA passes v1.12.0 with this one line change.
Further, line 195 of ENAdata.R contains [,,.SDcols=metaAvail]. This now throws a warning that i and j are both missing so the other arguments (.SDcols= in this case) are being ignored. It's likely that line is not doing what you intended.
When data.table v1.12.0 goes to CRAN, rENA will start to fail. Could you update rENA on CRAN please. Either in advance or after data.table v1.12.0 is there is ok too.
(If you are on GitHub I would submit a pull request.)
Best, Matt