fread drop when NULL in colClasses too #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jangorecki
approved these changes
Jan 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #3277 +/- ##
==========================================
+ Coverage 94.8% 94.81% +<.01%
==========================================
Files 65 65
Lines 12095 12094 -1
==========================================
Hits 11467 11467
+ Misses 628 627 -1
Continue to review full report at Codecov.
|
mattdowle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed warning as it occurred not just when there were duplicates in drop= but when drop specified columns that already had a NULL in that place of the colClasses= vector form. Now those NULLs in colClasses vector form work.
Package bsseq passes again now, #3233