as.data.table.list centralized #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3471 +/- ##
==========================================
+ Coverage 98.2% 98.23% +0.03%
==========================================
Files 66 66
Lines 12986 12926 -60
==========================================
- Hits 12753 12698 -55
+ Misses 233 228 -5
Continue to review full report at Codecov.
|
… coverage and avoided 3 test changes
…irst to reach the second via test 1940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data.tableandas.data.table.listwere very similar. Moved the logic intoas.data.table.listand called that fromdata.table().Original motivation was to unpack columns from a list of several data.frame which arose via jsonlite here: #3369 (comment). New tests 2057.* mimic that case and the
test.Rfile from the .zip in that issue passes with this PR.Another motivation was to get the common code into one place so it can then be ported to C eventually. C level not for speed but to use MAYBE_REFERENCED to only copy when needed.
Test 1484 strengthened to check fix for #842 still fixed (branch using point() removed).
CcopyNamedInList removed as
as.data.table.listnow does that.cbind(DT, list(...)) now creates list column so tests 1613.571-3 needed their list() wrappers removed. Those list() around factor(1) in those 3 tests seemed wrong anyway.
setDT(list)continues to be allowed to create NULL columns which is alleplusractually does and seems reasonable to continue to allow. Passeseplusrand no notice needs to be given after all. Turned back on check thatjcan't create NULL columns which was postponed from 1.12.2.