Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

between verbose, POSIXct support, RHS dot-alias, int64 support #3518

Merged
merged 31 commits into from
May 13, 2019
Merged

between verbose, POSIXct support, RHS dot-alias, int64 support #3518

merged 31 commits into from
May 13, 2019

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Apr 22, 2019 •
edited
Loading

closes #3516
closes #3519
closes #2315
closes #3517

@jangorecki jangorecki requested a review from mattdowle April 22, 2019 18:30
@codecov
Copy link

codecov bot commented Apr 22, 2019 •
edited
Loading

Codecov Report

Merging #3518 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
+ Coverage   97.43%   97.45%   +0.01%     
==========================================
  Files          66       66              
  Lines       12708    12801      +93     
==========================================
+ Hits        12382    12475      +93     
  Misses        326      326
Impacted Files Coverage Δ
R/between.R 100% <100%> (ø) ⬆️
src/forder.c 99.71% <100%> (ø) ⬆️
src/init.c 100% <100%> (ø) ⬆️
src/between.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf54f1f...89fa2cf. Read the comment docs.

@jangorecki jangorecki changed the title Between verbose between verbose, POSIXct support Apr 22, 2019
@jangorecki jangorecki changed the title between verbose, POSIXct support between verbose, POSIXct support, RHS dot-alias Apr 22, 2019
arunsrinivasan
arunsrinivasan reviewed Apr 23, 2019
View reviewed changes
R/between.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Apr 23, 2019
View reviewed changes
R/between.R Outdated Show resolved Hide resolved
jangorecki
jangorecki commented Apr 23, 2019
View reviewed changes
inst/tests/tests.Rraw Outdated Show resolved Hide resolved
@mattdowle mattdowle added this to the 1.12.4 milestone Apr 25, 2019
mattdowle
mattdowle requested changes Apr 27, 2019
View reviewed changes
Copy link
Member

@mattdowle mattdowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made the verbose changes. Just these points to clear up.

R/between.R Outdated Show resolved Hide resolved
R/between.R Outdated Show resolved Hide resolved
@jangorecki jangorecki changed the title between verbose, POSIXct support, RHS dot-alias [WIP] between verbose, POSIXct support, RHS dot-alias May 1, 2019
@jangorecki jangorecki changed the title [WIP] between verbose, POSIXct support, RHS dot-alias between verbose, POSIXct support, RHS dot-alias May 1, 2019
@jangorecki jangorecki changed the title between verbose, POSIXct support, RHS dot-alias [WIP] between verbose, POSIXct support, RHS dot-alias May 1, 2019
@jangorecki jangorecki added the WIP label May 1, 2019
@jangorecki
Copy link
Member Author

jangorecki commented May 1, 2019 •
edited
Loading

still adding int64 support, and better coercion for numeric #3517
edit: code is there, but still needs a lot of tests. for int64 experimental

jangorecki
jangorecki commented May 1, 2019
View reviewed changes
src/forder.c Show resolved Hide resolved
jangorecki
jangorecki commented May 1, 2019
View reviewed changes
src/between.c Outdated Show resolved Hide resolved
@jangorecki jangorecki changed the title [WIP] between verbose, POSIXct support, RHS dot-alias between verbose, POSIXct support, RHS dot-alias, int64 support May 2, 2019
@jangorecki jangorecki removed the WIP label May 2, 2019
@jangorecki jangorecki requested a review from mattdowle May 3, 2019 10:27
@mattdowle mattdowle merged commit 572b6e4 into master May 13, 2019
@mattdowle mattdowle deleted the between-verbose branch May 13, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico left review comments

@arunsrinivasan arunsrinivasan arunsrinivasan left review comments

@mattdowle mattdowle mattdowle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.4
4 participants
@jangorecki @mattdowle @arunsrinivasan @MichaelChirico